DEV-40930: Added ["change"] key to login-module status events. Changed

existing event calls to use state as "offline" or "online", with "change"
indicating the reason for this status event. Changed disconnect() to send
state "offline", change "disconnect" -- instead of replaying last auth
failure. Changed unit tests accordingly.
Changed LLLoginInstance::handleLoginEvent() to use LLEventDispatcher to route
calls to handleLoginFailure() et al.
Added LLEventDispatcher::get() to allow retrieving Callable by name and
testing for empty().

1 files changed, 7 insertions, 0 deletions

diff --git a/indra/newview/tests/lllogininstance_test.cpp b/indra/newview/tests/lllogininstance_test.cpp
index 75db76df27..009be35f64 100644
--- a/indra/newview/tests/lllogininstance_test.cpp
+++ b/indra/newview/tests/lllogininstance_test.cpp
@@ -225,6 +225,7 @@ namespace tut
 		// Dummy success response.

 		LLSD response;

 		response["state"] = "online";

+		response["change"] = "connect";

 		response["progress"] = 1.0;

 		response["transfer_rate"] = 7;

 		response["data"] = "test_data";

@@ -240,6 +241,7 @@ namespace tut
 

 		response.clear();

 		response["state"] = "offline";

+		response["change"] = "disconnect";

 		response["progress"] = 0.0;

 		response["transfer_rate"] = 0;

 		response["data"] = "test_data";

@@ -267,6 +269,7 @@ namespace tut
 		// TOS failure response.

 		LLSD response;

 		response["state"] = "offline";

+		response["change"] = "fail.login";

 		response["progress"] = 0.0;

 		response["transfer_rate"] = 7;

 		response["data"]["reason"] = "tos";

@@ -326,6 +329,7 @@ namespace tut
 		// Update needed failure response.

 		LLSD response;

 		response["state"] = "offline";

+		response["change"] = "fail.login";

 		response["progress"] = 0.0;

 		response["transfer_rate"] = 7;

 		response["data"]["reason"] = "update";

@@ -351,6 +355,7 @@ namespace tut
 		// Update needed failure response.

 		LLSD response;

 		response["state"] = "offline";

+		response["change"] = "fail.login";

 		response["progress"] = 0.0;

 		response["transfer_rate"] = 7;

 		response["data"]["reason"] = "update";

@@ -376,6 +381,7 @@ namespace tut
 		// Update needed failure response.

 		LLSD response;

 		response["state"] = "offline";

+		response["change"] = "fail.login";

 		response["progress"] = 0.0;

 		response["transfer_rate"] = 7;

 		response["data"]["reason"] = "optional";

@@ -401,6 +407,7 @@ namespace tut
 		// Update needed failure response.

 		LLSD response;

 		response["state"] = "offline";

+		response["change"] = "fail.login";

 		response["progress"] = 0.0;

 		response["transfer_rate"] = 7;

 		response["data"]["reason"] = "optional";