From d1d195ba904490c19faf2078560f49c3a6b16a18 Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Tue, 2 Mar 2010 09:58:34 +0000 Subject: CID-433 Checker: FORWARD_NULL Function: LLTabContainer::reshapeTuple(LLTabTuple *) File: /indra/llui/lltabcontainer.cpp --- indra/llui/lltabcontainer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'indra/llui/lltabcontainer.cpp') diff --git a/indra/llui/lltabcontainer.cpp b/indra/llui/lltabcontainer.cpp index 85ae13a889..30fc7babae 100644 --- a/indra/llui/lltabcontainer.cpp +++ b/indra/llui/lltabcontainer.cpp @@ -1649,7 +1649,7 @@ void LLTabContainer::reshapeTuple(LLTabTuple* tuple) if(mCustomIconCtrlUsed) { LLCustomButtonIconCtrl* button = dynamic_cast(tuple->mButton); - LLIconCtrl* icon_ctrl = button->getIconCtrl(); + LLIconCtrl* icon_ctrl = button ? button->getIconCtrl() : NULL; image_overlay_width = icon_ctrl ? icon_ctrl->getRect().getWidth() : 0; } else -- cgit v1.2.3 From 9272037c9d382c210b48379a209d89502ff48dd0 Mon Sep 17 00:00:00 2001 From: Paul Guslisty Date: Wed, 3 Mar 2010 09:47:58 +0200 Subject: Fixed normal bug EXT - 4572 (Click and hold the left mouse button doesn't let you browse tabbed IM floater) - Set mouse capture to the tab container in case of some control \"grab\" it during mouse hovering over tab container. --HG-- branch : product-engine --- indra/llui/lltabcontainer.cpp | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'indra/llui/lltabcontainer.cpp') diff --git a/indra/llui/lltabcontainer.cpp b/indra/llui/lltabcontainer.cpp index 30fc7babae..1dcfb4e296 100644 --- a/indra/llui/lltabcontainer.cpp +++ b/indra/llui/lltabcontainer.cpp @@ -2061,5 +2061,12 @@ void LLTabContainer::commitHoveredButton(S32 x, S32 y) tuple->mButton->onCommit(); } } + /** + * EXT - 4572 (Click and hold the left mouse button doesn't let you browse tabbed IM floater) + * + * During hovering mouse(with left mouse button hold) over tabs, a newly just activated corresponding + * to the tab(that is hovered in the given instant of time) panel may caught mouse capture. + */ + gFocusMgr.setMouseCapture(this); } } -- cgit v1.2.3 From ce27036017eb4c3e7b51f620597e50330232f38c Mon Sep 17 00:00:00 2001 From: Mike Antipov Date: Thu, 4 Mar 2010 16:22:31 +0200 Subject: Backed out changeset: 0160afd678a5 Implemented solution fixed bug caused by changes made for EXT-3852 (07f21c92896f & 07f21c92896f). For now previous changes for EXT-3852 are reverted. So, changes for EXT-4572 (Click and hold the left mouse button doesn't let you browse tabbed IM floater) are unnecessary. --HG-- branch : product-engine --- indra/llui/lltabcontainer.cpp | 7 ------- 1 file changed, 7 deletions(-) (limited to 'indra/llui/lltabcontainer.cpp') diff --git a/indra/llui/lltabcontainer.cpp b/indra/llui/lltabcontainer.cpp index 1dcfb4e296..30fc7babae 100644 --- a/indra/llui/lltabcontainer.cpp +++ b/indra/llui/lltabcontainer.cpp @@ -2061,12 +2061,5 @@ void LLTabContainer::commitHoveredButton(S32 x, S32 y) tuple->mButton->onCommit(); } } - /** - * EXT - 4572 (Click and hold the left mouse button doesn't let you browse tabbed IM floater) - * - * During hovering mouse(with left mouse button hold) over tabs, a newly just activated corresponding - * to the tab(that is hovered in the given instant of time) panel may caught mouse capture. - */ - gFocusMgr.setMouseCapture(this); } } -- cgit v1.2.3