Megapahit's fork of the Second Life viewer. https://www.megapahit.org/viewer.git/atom?h=main 2021-03-16T22:19:38Z 2021-03-16T22:19:38Z Andrey Kleshchev andreykproductengine@lindenlab.com 2021-03-16T22:19:38Z urn:sha1:6b73a8331f558f29903b797dedc09c7419958fdb 2017-09-06T13:04:59Z andreykproductengine andreykproductengine@lindenlab.com 2017-09-06T13:04:59Z urn:sha1:4a4d93d8c0c45248f76d6f27fb523b8ad361a473 2016-06-30T20:51:50Z Nat Goodspeed nat@lindenlab.com 2016-06-30T20:51:50Z urn:sha1:464a0df4c1d3e4073fe0bde506ac1d4aa194b02f The LLApp API used to consist of init(), mainLoop(), cleanup() methods. This makes sense -- but on Mac that structure was being subverted. The method called mainLoop() was in fact being called once per frame. There was initialization code in the method, which (on Mac) needed to be skipped with an already-initialized bool. There was a 'while' loop which (on Mac) needed to be turned into an 'if' instead so the method would return after every frame. Rename LLApp::mainLoop() to frame(). Propagate through subclasses LLAppViewer and LLCrashLogger. Document the fact that frame() returns true to mean "done." (This was always the case, but had to be inferred from the code.) Rename the Mac Objective-C function mainLoop to oneFrame. Rename the C++ free function it calls from runMainLoop() to pumpMainLoop(). Add comments to llappdelegate-objc.mm explaining (inferred) control flow. Change the Linux viewer main() and the Windows viewer WINMAIN() from a single LLAppViewer::mainLoop() call to repeatedly call frame() until it returns true. Move initialization code from the top of LLAppViewer::frame() to the init() method, where it more properly belongs. Remove corresponding mMainLoopInitialized flag (and all references) from LLAppViewer. Remove 'while (! LLApp::isExiting())' (or on Mac, 'if (! LLApp::isExiting())') from LLAppViewer::frame() -- thus unindenting the whole body of the 'while' and causing many lines of apparent change. (Apologies to reviewers.) There are four LLApp states: APP_STATUS_RUNNING, APP_STATUS_QUITTING, APP_STATUS_STOPPED and APP_STATUS_ERROR. Change LLAppViewer::frame() return value from (isExiting()) (QUITTING or ERROR) to (! isRunning()). I do not know under what circumstances the state might transition to STOPPED during a frame() call, but I'm quite sure that if it does, we don't want to call frame() again. We only want a subsequent call if the state is RUNNING. Also rename mainLoop() method in LLCrashLogger subclasses LLCrashLoggerWindows, LLCrashLoggerMac, LLCrashLoggerLinux. Of course it's completely up to the frame() method whether to yield control; none of those in fact do. Honor protocol by returning true (frame() is done), even though each one's main() caller ignores the return value. In fact LLCrashLoggerWindows::mainLoop() wasn't using the return protocol correctly anyway, returning wParam or 0 or 1 -- possibly because the return protocol was never explicitly documented. It should always return true: "I'm done, don't call me again." 2016-03-08T19:55:48Z Glenn Glazer coyot@lindenlab.com 2016-03-08T19:55:48Z urn:sha1:daf8b882a12cf903d180f6303065d7b83f7a1958 2014-04-22T18:19:28Z Xiaohong Bao bao@lindenlab.com 2014-04-22T18:19:28Z urn:sha1:ae564140c0ff1e05ebfab0752458313da0c07a79 2014-04-15T21:57:47Z Aura Linden aura@lindenlab.com 2014-04-15T21:57:47Z urn:sha1:a39c5926fccb2e7a209240fc29d2086f1ce78272 2014-04-08T02:09:40Z Richard Linden none@none 2014-04-08T02:09:40Z urn:sha1:98aabdc176c23de9ba23f902dc2015f9c775d26e 2014-03-26T01:30:39Z Aura Linden aura@lindenlab.com 2014-03-26T01:30:39Z urn:sha1:5b7929364b53ed1e4798ff4c7904014b6f423c0c 2014-03-25T21:05:51Z Aura Linden aura@lindenlab.com 2014-03-25T21:05:51Z urn:sha1:fdb65d2c28b5256d0442a2ab4499d04d91ecc96e 2014-03-25T05:44:51Z Aura Linden aura@lindenlab.com 2014-03-25T05:44:51Z urn:sha1:0893b49ebdd5c072f099ab7a9aa75d106c0c439b