#824 Process source files in bulk: replace tabs with spaces, convert CRLF to LF, and trim trailing whitespaces as needed

2024-04-29T04:56:09Z

DRTVWR-494: Move LL_ERRS out of llinstancetracker.h header file.

2020-03-25T19:28:17Z

Add a namespaced free function in .cpp file to report LL_ERRS as needed. Per code review, use a more indicative namespace name.

DRTVWR-494: Defend LLInstanceTracker against multi-thread usage.

2020-03-25T19:28:17Z

The previous implementation went to some effort to crash if anyone attempted to create or destroy an LLInstanceTracker subclass instance during traversal. That restriction is manageable within a single thread, but becomes unworkable if it's possible that a given subclass might be used on more than one thread. Remove LLInstanceTracker::instance_iter, beginInstances(), endInstances(), also key_iter, beginKeys() and endKeys(). Instead, introduce key_snapshot() and instance_snapshot(), the only means of iterating over LLInstanceTracker instances. (These are intended to resemble functions, but in fact the current implementation simply presents the classes.) Iterating over a captured snapshot defends against container modifications during traversal. The term 'snapshot' reminds the coder that a new instance created during traversal will not be considered. To defend against instance deletion during traversal, a snapshot stores std::weak_ptrs which it lazily dereferences, skipping on the fly any that have expired. Dereferencing instance_snapshot::iterator gets you a reference rather than a pointer. Because some use cases want to delete all existing instances, add an instance_snapshot::deleteAll() method that extracts the pointer. Those cases used to require explicitly copying instance pointers into a separate container; instance_snapshot() now takes care of that. It remains the caller's responsibility to ensure that all instances of that LLInstanceTracker subclass were allocated on the heap. Replace unkeyed static LLInstanceTracker::getInstance(T*) -- which returned nullptr if that instance had been destroyed -- with new getWeak() method returning std::weak_ptr. Caller must detect expiration of that weak_ptr. Adjust tests accordingly. Use of std::weak_ptr to detect expired instances requires engaging std::shared_ptr in the constructor. We now store shared_ptrs in the static containers (std::map for keyed, std::set for unkeyed). Make LLInstanceTrackerBase a template parameterized on the type of the static data it manages. For that reason, hoist static data class declarations out of the class definitions to an LLInstanceTrackerStuff namespace. Remove the static atomic sIterationNestDepth and its methods incrementDepth(), decrementDepth() and getDepth(), since they were used only to forbid creation and destruction during traversal. Add a std::mutex to static data. Introduce an internal LockStatic class that locks the mutex while providing a pointer to static data, making that the only way to access the static data. The LLINSTANCETRACKER_DTOR_NOEXCEPT macro goes away because we no longer expect ~LLInstanceTracker() to throw an exception in test programs. That affects LLTrace::StatBase as well as LLInstanceTracker itself. Adapt consumers to the new LLInstanceTracker API.

SL-10291 Replace apr_atomic with standard C++11 functionality

2019-01-15T16:31:17Z

remove execute permission from many files that should not have it

2015-11-10T14:48:56Z

crash fix - bad handling of instancetracker iterators

2013-10-18T20:10:40Z

merge with viewer-release

2013-06-06T02:05:43Z

SH-4080 WIP interesting: random crash on Mac

2013-04-20T03:09:00Z

removed unused dll support from llinstancetracker as it didn't appear to be thread safe

Update Mac and Windows breakpad builds to latest

2013-03-29T14:50:08Z

SH-3468 WIP add memory tracking base class

2012-12-23T20:27:25Z

fixed crash on exit by making LLInstanceTracker iterators use atomic iterator nesting count for thread safety

viewer.git/indra/llcommon/llinstancetracker.cpp, branch cef_147