Megapahit's fork of the Second Life viewer. https://www.megapahit.org/viewer.git/atom?h=cef_147 2026-01-24T16:42:55Z 2026-01-24T16:42:55Z Andrey Kleshchev 117672381+akleshchev@users.noreply.github.com 2026-01-23T20:51:27Z urn:sha1:e42ec63bfd7ada1087a00ca3ccc39c95679b7fab 2024-04-29T04:56:09Z Andrey Lihatskiy alihatskiy@productengine.com 2024-04-29T04:43:28Z urn:sha1:1b68f71348ecf3983b76b40d7940da8377f049b7 2021-06-23T23:07:40Z Nat Goodspeed nat@lindenlab.com 2021-06-11T21:06:50Z urn:sha1:a9b82b9d89aa3d0460d142fc520bc6a8ba79574e 2020-06-26T18:40:07Z Nat Goodspeed nat@lindenlab.com 2020-06-26T18:40:07Z urn:sha1:75b5f72e6951cae855a6abacc110a886e0ae701c Specifically, llcoro::suspendUntilTimeout() is definitely called concurrently by multiple coroutines. New code that instantiates a local LLEventStream must allow the name to be tweaked for uniqueness. 2020-06-26T00:59:04Z Nat Goodspeed nat@lindenlab.com 2020-06-26T00:59:04Z urn:sha1:1231cb4585290a26e29cca221f7c81fda3e2c623 Specifically, the shutdown crash reported in SL-13512 was due to LLExperienceCache::idleCoro() looping on suspendUntilTimeout(), failing to notice in its slumbers that the viewer was shutting down around it. Make suspendUntilTimeout() internally call suspendUntilEventOnWithTimeout(), which already listens for "LLApp" state-change events and throws Stopping when LLApp enters its shutdown sequence. 2020-03-25T23:24:25Z Nat Goodspeed nat@lindenlab.com 2019-11-22T16:58:27Z urn:sha1:2a56ab44360aa49bd0df9281efc8a8a97a510013 The new LLCoros::Stop exception is intended to terminate long-lived coroutines -- not interrupt mainstream shutdown processing. Only throw it on an explicitly-launched coroutine. Make LLCoros::getName() (used by the above test) static. As with other LLCoros methods, it might be called after the LLCoros LLSingleton instance has been deleted. Requiring the caller to call instance() implies a possible need to also call wasDeleted(). Encapsulate that nuance into a static method instead. 2020-03-25T23:02:24Z Nat Goodspeed nat@lindenlab.com 2019-10-24T20:05:37Z urn:sha1:26c8ccfc06bc9334c9a4d0d027e83ad0b1b92a86 2020-03-25T23:02:24Z Nat Goodspeed nat@lindenlab.com 2019-10-24T16:54:38Z urn:sha1:cbf146f2b3fc255bc83f2b01101dc29658bea6ea By the time "LLApp" listeners are notified that the app is quitting, the mainloop is no longer running. Even though those listeners do things like close work queues and inject exceptions into pending promises, any coroutines waiting on those resources must regain control before they can notice and shut down properly. Add a final "LLApp" listener that resumes ready coroutines a few more times. Make sure every other "LLApp" listener is positioned before that new one. 2020-03-25T23:02:24Z Nat Goodspeed nat@lindenlab.com 2019-10-23T00:48:36Z urn:sha1:7541e784d991888d6f600f4cb9439d5fcf15e452 unless we're going to reference it. 2020-03-25T23:02:24Z Nat Goodspeed nat@lindenlab.com 2019-10-22T21:14:26Z urn:sha1:1345a02b21a83bc4ee7ff72efc1858e956f18c53 Add LLCoros::TempStatus instances around known suspension points so printActiveCoroutines() can report what each suspended coroutine is waiting for. Similarly, sprinkle checkStop() calls at known suspension points. Make LLApp::setStatus() post an event to a new LLEventPump "LLApp" with a string corresponding to the status value being set, but only until ~LLEventPumps() -- since setStatus() also gets called very late in the application's lifetime. Make postAndSuspendSetup() (used by postAndSuspend(), suspendUntilEventOn(), postAndSuspendWithTimeout(), suspendUntilEventOnWithTimeout()) add a listener on the new "LLApp" LLEventPump that pushes the new LLCoros::Stopping exception to the coroutine waiting on the LLCoros::Promise. Make it return the new LLBoundListener along with the previous one. Accordingly, make postAndSuspend() and postAndSuspendWithTimeout() store the new LLBoundListener returned by postAndSuspendSetup() in a LLTempBoundListener (as with the previous one) so it will automatically disconnect once the wait is over. Make each LLCoprocedurePool instance listen on "LLApp" with a listener that closes the queue on which new work items are dispatched. Closing the queue causes the waiting dispatch coroutine to terminate. Store the connection in an LLTempBoundListener on the LLCoprocedurePool so it will disconnect automatically on destruction. Refactor the loop in coprocedureInvokerCoro() to instantiate TempStatus around the suspending call. Change a couple spammy LL_INFOS() calls to LL_DEBUGS(). Give all logging calls in that module a "CoProcMgr" tag to make it straightforward to re-enable the LL_DEBUGS() calls as desired.